Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 2.6 is dead #31

Merged
merged 7 commits into from
Apr 5, 2022
Merged

Ruby 2.6 is dead #31

merged 7 commits into from
Apr 5, 2022

Conversation

zaratan
Copy link
Contributor

@zaratan zaratan commented Apr 4, 2022 •
edited
Loading

@zaratan
Copy link
Contributor Author

zaratan commented Apr 4, 2022

@francoisjacques <3

francoisjacques
francoisjacques approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@francoisjacques francoisjacques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated comment in Gemfile, otherwise it looks good.

@zaratan @francoisjacques
Update shotgrid_api_ruby.gemspec
001dafc 
Co-authored-by: François Jacques <francoisjacques@users.noreply.github.com>
@zaratan
Copy link
Contributor Author

zaratan commented Apr 4, 2022

@francoisjacques I don't have the permissions to remove "tests (2.6)" from Github CI. Nor merge the PR for that matters.

@zaratan
Copy link
Contributor Author

zaratan commented Apr 4, 2022

Tests for Ruby 3.1 should be mandatory too.

@zaratan zaratan requested a review from francoisjacques April 5, 2022 07:24
@zaratan zaratan merged commit 243d3e1 into shotgunsoftware:main Apr 5, 2022
@zaratan zaratan deleted the 28_ruby_2.6_is_dead branch April 5, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisjacques francoisjacques francoisjacques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When ruby 2.6 is retired, allow active support 7+ in gemspec
2 participants
@zaratan @francoisjacques