Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed syntax error in .github/workflows/docs.yml #890

Merged

Conversation

alexmerlin
Copy link
Contributor


name: 🐞 Bug Fix
about: A new syntax error has been introduced with the latest commit for .github/workflows/docs.yml.
labels: bug


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion:

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

The latest commit for .github/workflows/docs.yml introduced a syntax error by using an incomplete variable - this PR fixes it.

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

Signed-off-by: alexmerlin <alex@dotkernel.com>
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (981ce2a) to head (fb9c2a9).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #890   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          806       806           
  Branches       291       291           
=========================================
  Hits           806       806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivammathur shivammathur merged commit 19ba822 into shivammathur:develop Dec 2, 2024
81 checks passed
@shivammathur
Copy link
Owner

@alexmerlin Thanks!

@alexmerlin alexmerlin deleted the fix-github-workflows-docs branch December 2, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants