[mem][linux] Expose oom_kill as part of SwapMemory #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oom_kill from `/proc/vmstat` represents the number of times OOM Killer killed a process. It's useful to debug process memory issues.
sfc-gh-smatejczyk
changed the title
sfc-gh-smatejczyk
changed the title
sfc-gh-rscott
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oom_killfrom/proc/vmstatrepresents the number of times OOM Killer killed a process.This PR proposes a simplistic approach to exposing it. Specifically, it includes the value of the counter in
SwapMemoryStat(for linux only).Alternatively, we could expose it in the
VirtualMemoryStatobject, where it seems to fit better. However, this will require opening/proc/vmstatforVirtualMemorycall. Currently,VirtualMemoryopens only/proc/meminfo, so that will be some overhead.Another approach would be to expose memory events as another struct and create a specific call for it.
Please advice.