Adapt GUI to new split optimization #65
Conversation
fsleyes_plugin_shimming_toolbox/components/checkbox_component.py
Outdated
Show resolved
Hide resolved
fsleyes_plugin_shimming_toolbox/components/dropdown_component.py
Outdated
Show resolved
Hide resolved
test/gui/test_b0shim_tab.py
Outdated
| @@ -21,7 +21,7 @@ def test_st_plugin_b0shim_dyn_lsq_mse(): | |||
| options = {'optimizer-method': 'Least Squares', | |||
| 'optimizer-criteria': 'Mean Squared Error', | |||
| 'slices': 'Auto detect', | |||
| 'scanner-coil-order': '1', | |||
| 'scanner-coil-order': '0,1,2', | |||
There was a problem hiding this comment.
Does this do something now that we use the checkboxes?
There was a problem hiding this comment.
It's just to test all checkboxes
There was a problem hiding this comment.
Yes but the option scanner-coil-order is not being used anymore. We hardcoded to click on all checkboxes in the test.
There was a problem hiding this comment.
maybe keep it to indicate what is going on in the test but add a comment to indicate that this parameter is not used.
Co-authored-by: Alex Dastous <47249340+po09i@users.noreply.github.com>
Co-authored-by: Alex Dastous <47249340+po09i@users.noreply.github.com>
Co-authored-by: Alex Dastous <47249340+po09i@users.noreply.github.com>
|
I updated to python 3.10, the installation now works. However, some tests are now failing. It seems to be related to the |
fsleyes_plugin_shimming_toolbox/components/checkbox_riro_component.py
Outdated
Show resolved
Hide resolved
test/gui/test_b0shim_tab.py
Outdated
| @@ -21,7 +21,7 @@ def test_st_plugin_b0shim_dyn_lsq_mse(): | |||
| options = {'optimizer-method': 'Least Squares', | |||
| 'optimizer-criteria': 'Mean Squared Error', | |||
| 'slices': 'Auto detect', | |||
| 'scanner-coil-order': '1', | |||
| 'scanner-coil-order': '0,1,2', | |||
There was a problem hiding this comment.
Yes but the option scanner-coil-order is not being used anymore. We hardcoded to click on all checkboxes in the test.
Co-authored-by: Alex Dastous <47249340+po09i@users.noreply.github.com>
Checklist
Description
With the new shimming-toolbox update letting users select specific orders from the scanner, this PR is to update the GUI prompts to use the new syntax. The GUI will only allow using all orders below the select one and use the same scanner orders and coils with riro and static.