Certificate issue failed: FinalizeOrder failed with "Value cannot be null. (Parameter 'value')"

[thozook]

I've setup the bot and it seems to fail whenever I have it request a certificate. I made sure that the app had permissions for DNS in the Resource Group and to manage certs in the Key Vault and that the Acmebot:VaultBaseUrl field has the URL of the Key Vault I'm using. The full error I'm seeing in the site log is as follows:

021-05-26T19:44:24.887 [Information] 5fa098fc01f2491e900b48928cd10603: Function 'IssueCertificate (Orchestrator)' awaited. IsReplay: False. State: Awaited. HubName: DurableFunctionsHub. AppName: func-WSSAMSCertbot-qvve. SlotName: Production. ExtensionVersion: 2.4.3. SequenceNumber: 40.
2021-05-26T19:44:24.900 [Information] 5fa098fc01f2491e900b48928cd10603: Function 'FinalizeOrder (Activity)' started. IsReplay: False. Input: (3980 bytes). State: Started. HubName: DurableFunctionsHub. AppName: func-WSSAMSCertbot-qvve. SlotName: Production. ExtensionVersion: 2.4.3. SequenceNumber: 41. TaskEventId: 10
2021-05-26T19:44:24.901 [Information] Executing 'FinalizeOrder' (Reason='(null)', Id=0f1d449f-35c7-41db-b76b-0762a9b6876e)
2021-05-26T19:44:24.915 [Error] Executed 'FinalizeOrder' (Failed, Id=0f1d449f-35c7-41db-b76b-0762a9b6876e, Duration=14ms)
Value cannot be null. (Parameter 'value')
2021-05-26T19:44:25.062 [Error] 5fa098fc01f2491e900b48928cd10603: Function 'FinalizeOrder (Activity)' failed with an error. Reason: System.ArgumentNullException: Value cannot be null. (Parameter 'value')
   at Azure.Security.KeyVault.Certificates.CertificateKeyType..ctor(String value)
   at KeyVault.Acmebot.Models.CertificatePolicyItem.ToCertificatePolicy() in /home/runner/work/keyvault-acmebot/keyvault-acmebot/KeyVault.Acmebot/Models/CertificatePolicyItem.cs:line 42
   at KeyVault.Acmebot.Functions.SharedActivity.FinalizeOrder(ValueTuple`2 input) in /home/runner/work/keyvault-acmebot/keyvault-acmebot/KeyVault.Acmebot/Functions/SharedActivity.cs:line 343
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionInvoker`2.InvokeAsync(Object instance, Object[] arguments) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionInvoker.cs:line 52
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.InvokeWithTimeoutAsync(IFunctionInvoker invoker, ParameterHelper parameterHelper, CancellationTokenSource timeoutTokenSource, CancellationTokenSource functionCancellationTokenSource, Boolean throwOnTimeout, TimeSpan timerInterval, IFunctionInstance instance) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionExecutor.cs:line 555
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.ExecuteWithWatchersAsync(IFunctionInstanceEx instance, ParameterHelper parameterHelper, ILogger logger, CancellationTokenSource functionCancellationTokenSource) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionExecutor.cs:line 501
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.ExecuteWithLoggingAsync(IFunctionInstanceEx instance, FunctionStartedMessage message, FunctionInstanceLogEntry instanceLogEntry, ParameterHelper parameterHelper, ILogger logger, CancellationToken cancellationToken) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionExecutor.cs:line 279. IsReplay: False. State: Failed. HubName: DurableFunctionsHub. AppName: func-WSSAMSCertbot-qvve. SlotName: Production. ExtensionVersion: 2.4.3. SequenceNumber: 42. TaskEventId: 10
2021-05-26T19:44:25.121 [Information] Executing 'IssueCertificate' (Reason='(null)', Id=732aa996-7521-4df3-bda9-f65bcad58ba1)
2021-05-26T19:44:25.128 [Error] 5fa098fc01f2491e900b48928cd10603: Function 'IssueCertificate (Orchestrator)' failed with an error. Reason: Microsoft.Azure.WebJobs.Extensions.DurableTask.FunctionFailedException: The activity function 'FinalizeOrder' failed: "Value cannot be null. (Parameter 'value')". See the function execution logs for additional details.
 ---> System.ArgumentNullException: Value cannot be null. (Parameter 'value')
   at Azure.Security.KeyVault.Certificates.CertificateKeyType..ctor(String value)
   at KeyVault.Acmebot.Models.CertificatePolicyItem.ToCertificatePolicy() in /home/runner/work/keyvault-acmebot/keyvault-acmebot/KeyVault.Acmebot/Models/CertificatePolicyItem.cs:line 42
   at KeyVault.Acmebot.Functions.SharedActivity.FinalizeOrder(ValueTuple`2 input) in /home/runner/work/keyvault-acmebot/keyvault-acmebot/KeyVault.Acmebot/Functions/SharedActivity.cs:line 343
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionInvoker`2.InvokeAsync(Object instance, Object[] arguments) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionInvoker.cs:line 52
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.InvokeWithTimeoutAsync(IFunctionInvoker invoker, ParameterHelper parameterHelper, CancellationTokenSource timeoutTokenSource, CancellationTokenSource functionCancellationTokenSource, Boolean throwOnTimeout, TimeSpan timerInterval, IFunctionInstance instance) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionExecutor.cs:line 555
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.ExecuteWithWatchersAsync(IFunctionInstanceEx instance, ParameterHelper parameterHelper, ILogger logger, CancellationTokenSource functionCancellationTokenSource) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionExecutor.cs:line 501
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.ExecuteWithLoggingAsync(IFunctionInstanceEx instance, FunctionStartedMessage message, FunctionInstanceLogEntry instanceLogEntry, ParameterHelper parameterHelper, ILogger logger, CancellationToken cancellationToken) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionExecutor.cs:line 279
   --- End of inner exception stack trace ---
   at Microsoft.Azure.WebJobs.Extensions.DurableTask.DurableOrchestrationContext.CallDurableTaskFunctionAsync[TResult](String functionName, FunctionType functionType, Boolean oneWay, String instanceId, String operation, RetryOptions retryOptions, Object input, Nullable`1 scheduledTimeUtc) in D:\a\r1\a\azure-functions-durable-extension\src\WebJobs.Extensions.DurableTask\ContextImplementations\DurableOrchestrationContext.cs:line 710
   at KeyVault.Acmebot.Functions.SharedOrchestrator.IssueCertificate(IDurableOrchestrationContext context) in /home/runner/work/keyvault-acmebot/keyvault-acmebot/KeyVault.Acmebot/Functions/SharedOrchestrator.cs:line 51
   at Microsoft.Azure.WebJobs.Host.Executors.VoidTaskMethodInvoker`2.InvokeAsync(TReflected instance, Object[] arguments) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\VoidTaskMethodInvoker.cs:line 20
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionInvoker`2.InvokeAsync(Object instance, Object[] arguments) in C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Executors\FunctionInvoker.cs:line 52
   at Microsoft.Azure.WebJobs.Extensions.DurableTask.TaskOrchestrationShim.InvokeUserCodeAndHandleResults(RegisteredFunctionInfo orchestratorInfo, OrchestrationContext innerContext) in D:\a\r1\a\azure-functions-durable-extension\src\WebJobs.Extensions.DurableTask\Listener\TaskOrchestrationShim.cs:line 150. IsReplay: False. State: Failed. HubName: DurableFunctionsHub. AppName: func-WSSAMSCertbot-qvve. SlotName: Production. ExtensionVersion: 2.4.3. SequenceNumber: 43. TaskEventId: -1
2021-05-26T19:44:25.165 [Error] Executed 'IssueCertificate' (Failed, Id=732aa996-7521-4df3-bda9-f65bcad58ba1, Duration=43ms)
Orchestrator function 'IssueCertificate' failed: The activity function 'FinalizeOrder' failed: "Value cannot be null. (Parameter 'value')". See the function execution logs for additional details.

Function execution log for FinalizeOrder just has the "Value cannot be null" line. Not sure where to look for the source of the issue

[shibayan]

What settings did you use to try to issue the certificate?
Have you set the Advanced options? If so, can you share how you set them?

[thozook]

I attempted to issue the cert using the REST API(as I'm attempting to include this in some automation). The CURL command I used to issue the cert is as follows:
curl -v --header "Content-Type: application/json" --data '{"DnsNames": ["##DOMAIN##.com"]}' https://func-##BOTNAME##-qvve.azurewebsites.net/api/certificate?code=##APPKEY##

I got the 202 accepted response to the command.

Application Settings:
Acmebot:VaultBaseUrl was set during deployment and is set to "https://kv-##REDACTED##.vault.azure.net/"
Acmebot:Contacts was set during deployment and is set to my work email address
Acmebot:Endpoint is set to https://acme-v02.api.letsencrypt.org/

As we are using Azure DNS:
Acmebot:AzureDns:SubscriptionId is set.

Application was given the "Certificate Management" template permissions in the Key Vault and the "DNS Zone Contributor" role in the Resource Group.

I can confirm by looking at the Activity Log in the DNS Zone for the domain that it is successfully adding and removing the verification TXT records.

[shibayan]

This issue has been fixed in PR #325. An error occurred when the KeyType did not exist in the request data.
It will work correctly after v3.6.1 is released.

[shibayan]

I have released v3.6.1 and it should work correctly after restarting the Functions App from Azure Portal.

[thozook]

Certificate was successfully issued after restarting the Functions app. Thank you!