Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petite Pewter Orangutan - LenderCommitmentGroupShares missing msg.sender on constructor's Ownable() #68

Open
sherlock-admin3 opened this issue Dec 10, 2024 · 0 comments

Comments

@sherlock-admin3
Copy link
Contributor

Petite Pewter Orangutan

High

LenderCommitmentGroupShares missing msg.sender on constructor's Ownable()

Summary

LenderCommitmentGroupShares missing msg.sender on constructor's Ownable()

Impact

It will not be possible to deploy the contract with the correct ownership.

PoC

LenderCommitmentGroupShares::constructor

    constructor(string memory _name, string memory _symbol, uint8 _decimals)
        ERC20(_name, _symbol)
@>      Ownable()
    {
        DECIMALS = _decimals;
    }

Mitigation

Add msg.sender on the constructor's Ownable()

    constructor(string memory _name, string memory _symbol, uint8 _decimals)
        ERC20(_name, _symbol)
-       Ownable()
+       Ownable(msg.sender)
    {
        DECIMALS = _decimals;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant