0x73696d616f - GoodDollarExpansionController inherits PausableUpgradeable but does not make any function pausable

[sherlock-admin2]

0x73696d616f

Medium

GoodDollarExpansionController inherits PausableUpgradeable but does not make any function pausable

Summary

GoodDollarExpansionController inherits PausableUpgradeable but does not have any pausing functionality implemented. This renders the inherited PausableUpgradeable useless and will make it impossible to pause this contract.

Root Cause

In GoodDollarExpansionController:137,153,170,192, the whenNotPaused modifier is not implemented as well as functions to set paused or unpaused.

It calls some functions in GoodDollarExchangeProvider that may be paused there, but it would pause all functions in GoodDollarExchangeProvider, and the protocol may intend to pause only the functions exposed in GoodDollarExpansionController.

Internal pre-conditions

None.

External pre-conditions

None.

Attack Path

1. Protocol tries to pause GoodDollarExpansionController functions but fails to do so.

Impact

GoodDollarExpansionController can not be paused.

PoC

Check the contract here.

Mitigation

Implement whenNotPause modifiers in the functions and create functions to pause/unpause the contract.

[sherlock-admin2]

The protocol team fixed this issue in the following PRs/commits:
mento-protocol/mento-core#552