Skip to content

Latest commit

 

History

History
48 lines (26 loc) · 1.53 KB

083.md

File metadata and controls

48 lines (26 loc) · 1.53 KB

Loud Mocha Platypus

Medium

Tarot Oracle Broken

Summary

Uses wrong interface for UniswapV2Pair.sol in the Tarot Oracle. The state variable reserve0CumulativeLast inside IUniswapV2Pair.reserve0CumulativeLast does not exist, and will revert when called in the Tarot Oracle, during Mix Oracle use.

Note: Tarot Oracle hasn't ran in 1 year

Official UniswapV2Pair.sol uses price0CumulativeLast instead of reserve0CumulativeLast.

Root Cause

See Summary.

Internal pre-conditions

See Summary.

External pre-conditions

See Summary.

Attack Path

See Summary.

Impact

Mix oracle broken as a result of tarot oracle breaking, which means this backup oracle fails which is bad.

PoC

None.

Mitigation

  • Do not use Tarot Oracle or determine if it has been mended somewhere.