extensions: randr: fix RR-GET-OUTPUT-INFO indices #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulapatience
force-pushed
the
bugfix/rr-get-output-info
branch
4 times, most recently
from
c76fe19 to
97d8ba6
Compare
The CRTC-START index was incorrect, which caused RR-GET-OUTPUT-INFO to return bogus CRTCs, modes, clones, and name. Additionally, document the function's multiple return values and declaim its type. The latter required adding some types and adjusting some existing types and constants. Finally, reindent RR-GET-OUTPUT-INFO, wrap some overlong lines, and clean up some comments and whitespace.
paulapatience
force-pushed
the
bugfix/rr-get-output-info
branch
from
97d8ba6 to
9336594
Compare
dkochmanski
requested changes
Jul 13, 2020
|
please resolve conflicts; after that I'm OK with merging this as is. thank you. |
|
What's the status on this? |
I can take a look at this again soon. However, I wonder if I should revert the |
|
key is fine, it makes the interface better. optional arguments get nasty quick if there is more than one. |
This was referenced Jan 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRTC-START index was incorrect, which caused RR-GET-OUTPUT-INFO to return bogus CRTCs, modes, clones, and name.
Additionally, document the function's multiple return values and declaim its type. The latter required adding some types and adjusting some existing types and constants.
Finally, reindent RR-GET-OUTPUT-INFO, wrap some overlong lines, and clean up some comments and whitespace.