Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows sidebar to be closed when project ID exists #77

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

simonbs
Copy link
Contributor

@simonbs simonbs commented Oct 27, 2023

Fixes an issue where the sidebar could not be closed on mobile when the "The project was not found" error message was shown because project was undefined.

This is an issue when the user opens a project that does not exist by navigating directly to the URL, e.g. by visiting docs.shapetools.io/foo, because the sidebar would remain open on mobile preventing the user from seeing the error message.

@simonbs simonbs self-assigned this Oct 27, 2023
@simonbs simonbs merged commit 0adb2ea into develop Oct 27, 2023
3 checks passed
@simonbs simonbs deleted the bugfix/sidebar-cannot-be-closed branch October 27, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant