Make sure file proxy endpoint only serves JSON or YAML #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does so by parsing the file's text using the yaml library. If it is parsed correctly we return the file's text. If not we return an error.
ulrikandersen
force-pushed
the
fix/make-sure-proxy-only-serves-json-or-yaml
branch
from
81744ee to
30d3a0b
Compare
ulrikandersen
deleted the
fix/make-sure-proxy-only-serves-json-or-yaml
branch
This was referenced Oct 28, 2024
Merged
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic to the
/api/proxyendpoint which ensures we only serve valid JSON or YAML.Motivation and Context
This important because we could otherwise risk serving HTML which may contain malicious JavaScript (XSS).
The file's text is parsed using the
yamllibrary. If it is parsed correctly we return the file's text. If not we return an error.We can parse both JSON and YAML it using the
yamllibrary because JSON is a subset of YAML.Types of changes