Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/proxy cancels downloading large files and long operations #416

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

simonbs
Copy link
Contributor

@simonbs simonbs commented Oct 24, 2024

Description

The /api/proxy endpoint will cancel downloading if the downloaded file exceeds 10 MB or if the operation takes longer than 30 seconds.

Motivation and Context

This addresses an issue where our container could terminate in an attempt to download large files. It also prevents downloading for an infinite amount of time.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@simonbs simonbs self-assigned this Oct 24, 2024
@simonbs simonbs changed the title /api/proxy cancels downloading lang files and long operations /api/proxy cancels downloading large files and long operations Oct 24, 2024
Copy link

⚠️ It looks like .env.example has changed. Remember to update the Setting Environment Variables article accordingly.

@simonbs simonbs enabled auto-merge October 24, 2024 09:43
@simonbs simonbs merged commit 0c00f35 into develop Oct 25, 2024
8 checks passed
@simonbs simonbs deleted the bugfix/cancel-downloading-large-files branch October 25, 2024 11:03
@ulrikandersen ulrikandersen mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants