Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Welcome & Not Found page #311

Merged
merged 10 commits into from
Aug 20, 2024
Merged

feat: Welcome & Not Found page #311

merged 10 commits into from
Aug 20, 2024

Conversation

mpabarca
Copy link
Contributor

@mpabarca mpabarca commented Aug 8, 2024

Description

  • Create welcome page (desktop and mobile).

  • This page includes an UI layer with some "guidance/tips" on how to use the dashboard, that will depend of the status of the user. (see screenshots)
    -> If there is not project on the user dashboard
    -> If somehow the browser lose the session from the user or is still loading so it's show placeholder

  • Change [[...slug]] route to [...slug] so now the path "/" is not included on that layout.

  • Create folder (welcome) to locate this "/" route with an specific layout and page.

  • Create a Not Found page

Motivation and Context

Now that more people (and possibly more companies) are joining, it might be a good idea to improve the UI and UX to make navigating the platform more enjoyable.

Screenshots:

Screenshot 2024-08-08 at 15 03 00

Special cases
Screenshot 2024-08-09 at 13 20 24
Screenshot 2024-08-09 at 13 23 14

Mobile version

Screenshot 2024-08-09 at 13 21 41

Not Found page

Screenshot 2024-08-09 at 14 40 30 Screenshot 2024-08-09 at 14 58 05

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mpabarca mpabarca changed the title Feature/welcome page feat: Welcome Page Aug 8, 2024
@mpabarca mpabarca force-pushed the feature/welcome-page branch from dd85590 to 74cd498 Compare August 9, 2024 11:39
@mpabarca mpabarca marked this pull request as ready for review August 9, 2024 12:11
@mpabarca mpabarca self-assigned this Aug 9, 2024
@mpabarca mpabarca force-pushed the feature/welcome-page branch 2 times, most recently from 2d434d2 to e0eb020 Compare August 9, 2024 12:46
@mpabarca mpabarca changed the title feat: Welcome Page feat: Welcome & Not Found page Aug 9, 2024
@mpabarca mpabarca force-pushed the feature/welcome-page branch 2 times, most recently from 696ae0c to 5b87e71 Compare August 9, 2024 13:43
Copy link
Contributor

@simonbs simonbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on making the Not Found and Welcome pages more engaging! The Not Found page looks perfect, but I’ve left some comments on the Welcome page for your thoughts.

My main suggestion is to reduce the amount of content on the Welcome page. Currently, there’s a lot happening, which might overwhelm users and make it harder for them to know what to focus on.

Additionally, would it make sense to convert the help text with arrows into traditional, dismissible tooltips? This way, returning users won't see content that's no longer relevant to them. We could track whether the tooltip is hidden using local storage, avoiding any need to modify the database schema.

src/features/welcome/view/ShowSectionsLayer.tsx Outdated Show resolved Hide resolved
src/features/welcome/view/ShowSectionsLayer.tsx Outdated Show resolved Hide resolved
src/features/welcome/view/ShowSectionsLayer.tsx Outdated Show resolved Hide resolved
src/features/welcome/view/WelcomeContent.tsx Outdated Show resolved Hide resolved
Base automatically changed from feature/new-project-page to develop August 14, 2024 06:52
@mpabarca mpabarca force-pushed the feature/welcome-page branch from 5b87e71 to b5176ad Compare August 14, 2024 08:03
@mpabarca
Copy link
Contributor Author

mpabarca commented Aug 15, 2024

Additionally, would it make sense to convert the help text with arrows into traditional, dismissible tooltips? This way, returning users won't see content that's no longer relevant to them. We could track whether the tooltip is hidden using local storage, avoiding any need to modify the database schema.

@simonbs I like the idea! I started implementing it, but I noticed something related to the strict mode we have in the app’s development environment. I’d like to address this "bug" before moving forward, , as it affects the correct behaviour needed to achieve this idea.

Would it be possible to leave it this way for now, and in the next PR, I can add this cool idea and hopefully solve the issue?

@mpabarca mpabarca requested a review from simonbs August 15, 2024 08:24
@simonbs simonbs merged commit 34b9f5e into develop Aug 20, 2024
5 checks passed
@simonbs simonbs deleted the feature/welcome-page branch August 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants