Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a
try {} catch {}
on the sign in page. The catch block merely printed the error. However, this resulted in the following error being logged upon every sign in with GitHub.As far as I can tell from this blog post this error isn't a "real" error that's meant to be handled but rather a signal to Next.js that it needs to do a redirect.
Since we're not doing any interesting error handling, I thought we might as well remove the try/catch entirely and rely on Next.js to handle any error thrown. At least this avoids polluting our logs with errors that we cannot and should not do anything about.