Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores files starting with dot and residing in directory when posting PR #252

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

simonbs
Copy link
Contributor

@simonbs simonbs commented Jul 18, 2024

This PR adjusts the logic for the files included in PR comments. The logic is as follows:

  • YAML files with the .yml or .yaml extension are included.
  • YAML files are required to reside in the root of the repository.
  • YAML files starting with a dot (.) are ignored.
  • Only exception to the above rule is the project configuration file which is allowed to start with a dot, e.g. .shape-docs.yml

@simonbs simonbs requested a review from ulrikandersen as a code owner July 18, 2024 14:02
@simonbs simonbs changed the title Enhancement/filter filenames Ignores files starting with dot and residing in directory when posting PR Jul 18, 2024
@simonbs simonbs enabled auto-merge July 18, 2024 14:14
Copy link
Contributor

@ulrikandersen ulrikandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 for the unit tests

@simonbs simonbs merged commit 65a63c3 into develop Jul 18, 2024
4 checks passed
@simonbs simonbs deleted the enhancement/filter-filenames branch July 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants