Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifier Shadows Ignore Fog #73

Open
shaddatic opened this issue Feb 16, 2024 · 2 comments
Open

Modifier Shadows Ignore Fog #73

shaddatic opened this issue Feb 16, 2024 · 2 comments
Labels
priority-low Low priority rel-cheapshadow Issue related to the modifier shadows render-fix Only present with Render Fix

Comments

@shaddatic
Copy link
Owner

Modifier shadows currently ignore fog, causing them to stand out much more significantly than they should. First image from issue #61.

Render Fix:
277438063-260609f4-b373-4f7e-bd45-fc5ac3784ea9

Dreamcast:
image
@shaddatic shaddatic added old-dreamcast Is found & working on the Dreamcast version old-render-fix Issue related to the mod itself render-fix Only present with Render Fix rel-cheapshadow Issue related to the modifier shadows and removed old-render-fix Issue related to the mod itself labels Feb 16, 2024
shaddatic added a commit that referenced this issue Aug 10, 2024
@shaddatic
Modifiers now read the fog color before drawing by checking the fog c…
5e3be30 
…olor at a point 10m away, and blending the modifier color with that color. This mostly addresses issue #73, but not entirely. A better solution is not currently possible, such as per pixel blending, so the issue will remain open
@shaddatic
Copy link
Owner Author

The issue has been mostly addressed, but it will need to be returned to at some point. However, better solutions are also not possible at this time, sadly. The current solution is not perfect, but is perfect enough to now consider this issue 'low priority'.

213610_20240810112851_1

@shaddatic shaddatic added priority-low Low priority and removed old-dreamcast Is found & working on the Dreamcast version labels Aug 10, 2024
@Ellasent
Copy link

Ellasent commented Sep 5, 2024 •
edited
Loading

It seems the current fix in place doesn't affect Death Chamber and EGG Quarters.
image
image
I don't know if this is what you were referring to when you stated "mostly addressed" and "isn't perfect", but if not I figured it'd be good to mention just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-low Low priority rel-cheapshadow Issue related to the modifier shadows render-fix Only present with Render Fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ellasent @shaddatic