Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump v0.3.6.post3 #2259

Merged
merged 2 commits into from
Nov 29, 2024
Merged

chore: bump v0.3.6.post3 #2259

merged 2 commits into from
Nov 29, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Nov 29, 2024

Motivation

install with one-click, set flashinfer in deps

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@@ -3,9 +3,8 @@ Install the dependency in CI.
"""

pip install --upgrade pip
pip install -e "python[all]"
pip install -e "python[all]" --find-links https://flashinfer.ai/whl/cu121/torch2.4/flashinfer/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use --extra-index-url ? Because https://github.com/flashinfer-ai/whl is HTML
When I use pip index versions flashinfer --index-url https://flashinfer.ai/whl/cu121/

WARNING: The directory '/root/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
WARNING: pip index is currently an experimental command. It may be removed/changed in a future release without prior warning.
flashinfer (0.0.1+cu121)
Available versions: 0.0.1+cu121
  INSTALLED: 0.1.6+cu121torch2.4
  LATEST:    0.0.1+cu121

It can't get the right LATEST

@zhyncs
Copy link
Member Author

zhyncs commented Nov 29, 2024

Docker v0.3.6.post3 can be overridden, so don't worry about it.

@zhyncs zhyncs requested review from yzh119 and merrymercy November 29, 2024 17:30
@zhyncs
Copy link
Member Author

zhyncs commented Nov 29, 2024

Locally verified

@zhyncs zhyncs merged commit fae4e5e into main Nov 29, 2024
22 checks passed
@zhyncs zhyncs deleted the zhyncs/dep branch November 29, 2024 17:41
@zhyncs
Copy link
Member Author

zhyncs commented Nov 29, 2024

Another purpose of this PR is to support a Dockerfile.dev #2060 in the future, where we can specify the flashinfer index as nightly in dev.
ref flashinfer-ai/flashinfer-nightly#1 (comment)

@zhyncs
Copy link
Member Author

zhyncs commented Nov 29, 2024

docker pull lmsysorg/sglang:latest

# need to setup HF_TOKEN
docker run --gpus all \
    --shm-size 32g \
    -p 30000:30000 \
    -v /opt/dlami/nvme/.cache:/root/.cache \
    -v /tmp:/tmp \
    --ipc=host \
    lmsysorg/sglang:latest \
    python3 -m sglang.launch_server --model-path meta-llama/Llama-3.1-8B-Instruct --host 0.0.0.0 --port 30000 --disable-radix

This works well with v0.3.6.post3

@zhyncs
Copy link
Member Author

zhyncs commented Nov 29, 2024

ref flashinfer-ai/whl#1

@merrymercy
Copy link
Contributor

Will this break AMD?

@HaiShaw
Copy link
Collaborator

HaiShaw commented Nov 29, 2024

It is okay to AMD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants