base bms cli

[lonamle]

Feature

prints various messages when user presses different keys

Implementation

receives input with sciReceive(), prints with UARTprintf(), if-statements use input to determine output

Testing

Test steps:

1. launch debugger
2. open serial terminal
3. press keys (1, 2, 3)

Bugs (aka features)

the same message cannot be printed multiple times in a row, even if key is pressed again

[rafguevara14]

looks good! just a few comments about code readability

[rafguevara14]

when creating actual commands let's use proper macros. This makes it easier to read and change and uses no program memory because the values are placed at compile time

#define DO_SMT_CMD '1'

if (msg == DO_SMT_CMD)
...

[rafguevara14]

Now that the code is written it's easier to see that a switch statement fits more nicely with this logic.

switch(param)
{
    case param:
          
           // do the thing 
           break;
}

[rafguevara14]

it's easy to see now that there are 3 logical parts:

1. wait for a message
2. dispatch/process message
3. update variables

// wait for user input
uint8 msg;
sciReceive();

// process input
if ()
{
}

// update previous
previous = msg;

vTaskDelay(1000);

spacing (along with comments) can make this clearer