-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mute feature [request] #46
Comments
Hello! You can already in/decrease the volume with keybinds, or pause the music. |
If you pause music, nothing should ever play. If no music was playing, it shouldn't be able to play a music (display would be broken otherwise).
I released a new version that pause the music player when not playing music, so that if no music is playing, it won't play music later, as you would expect for a mute. Don't hesitate to try it out and tell me if that's enough in your opinion! |
maybe immidite mute would be a cool addition? :3 |
Immediate mute? Doesn't pausing music immediately "mute" the music? What do you mean exactly? |
Hi again! Please let me know if current features are not sufficient for this request. |
Sorry for accidentally closing it, but correct me if I am wrong, but I think music in the title menus still plays even when paused. It would be nice if there was a mute button just like on a computer. |
If the title menus, you don't have access to keybinds, so you can't pause the music. However, if you pause the music in-game and go back to the title menus, music won't play again. However, the purpose of the mod is to control how music is played in-game. I don't plan to add things in the title menus to control the music, even though I keep this idea on a sidenote as mentioned in #21. If that's the only thing missing from this issue, I will close it as I consider it out of scope of the mod, and I already keep one issue opened for title menu controls. |
It would be nice if I could just mute music with one button press. Maybe add a keybind to mute and unmute music.
The text was updated successfully, but these errors were encountered: