Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mute feature [request] #46

Closed
Qsta981 opened this issue Nov 28, 2023 · 7 comments
Closed

Add mute feature [request] #46

Qsta981 opened this issue Nov 28, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@Qsta981
Copy link

Qsta981 commented Nov 28, 2023

It would be nice if I could just mute music with one button press. Maybe add a keybind to mute and unmute music.

@Qsta981 Qsta981 changed the title Add mute feature Add mute feature #feature Nov 28, 2023
@Qsta981 Qsta981 changed the title Add mute feature #feature Add mute feature Nov 28, 2023
@Qsta981 Qsta981 changed the title Add mute feature Add mute feature [request] Nov 28, 2023
@charlyb01 charlyb01 added the enhancement New feature or request label Nov 29, 2023
@charlyb01
Copy link
Member

Hello! You can already in/decrease the volume with keybinds, or pause the music.
But I guess it's a bit different, as you can't pause if there is no music playing. I guess I could just enhance the pause keybind, what do you think?

charlyb01 added a commit that referenced this issue Dec 6, 2023
If you pause music, nothing should ever play. If no music was playing, it shouldn't be able to play a music (display would be broken otherwise).
@charlyb01
Copy link
Member

I released a new version that pause the music player when not playing music, so that if no music is playing, it won't play music later, as you would expect for a mute. Don't hesitate to try it out and tell me if that's enough in your opinion!

@Anoaxx
Copy link

Anoaxx commented Dec 21, 2023

maybe immidite mute would be a cool addition? :3

@charlyb01
Copy link
Member

Immediate mute? Doesn't pausing music immediately "mute" the music? What do you mean exactly?

@charlyb01
Copy link
Member

Hi again! Please let me know if current features are not sufficient for this request.

@Qsta981 Qsta981 closed this as completed Apr 7, 2024
@Qsta981 Qsta981 reopened this Apr 7, 2024
@Qsta981
Copy link
Author

Qsta981 commented Apr 7, 2024

Sorry for accidentally closing it, but correct me if I am wrong, but I think music in the title menus still plays even when paused. It would be nice if there was a mute button just like on a computer.

@charlyb01
Copy link
Member

If the title menus, you don't have access to keybinds, so you can't pause the music. However, if you pause the music in-game and go back to the title menus, music won't play again.

However, the purpose of the mod is to control how music is played in-game. I don't plan to add things in the title menus to control the music, even though I keep this idea on a sidenote as mentioned in #21. If that's the only thing missing from this issue, I will close it as I consider it out of scope of the mod, and I already keep one issue opened for title menu controls.

@Qsta981 Qsta981 closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants