Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Music [request] #25

Open
Anoaxx opened this issue Sep 14, 2022 · 9 comments
Open

Continuous Music [request] #25

Anoaxx opened this issue Sep 14, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@Anoaxx
Copy link

Anoaxx commented Sep 14, 2022

I was thinking recently about something... why we cant listen to music continouously, without stopping music in pause menu/leaving world/server and changing immidetaly in main menu. Is it even possible yet?

@charlyb01
Copy link
Member

Hi again!
I was going to check this actually because someone else asked me the same thing. I don't know if it's possible, maybe it checks for specific resource pack when loading a world. I will check it after the GUI, which is almost done 😉

@charlyb01 charlyb01 added the enhancement New feature or request label Sep 15, 2022
@Anoaxx
Copy link
Author

Anoaxx commented Dec 2, 2023

bump

@charlyb01
Copy link
Member

I was focusing on the last major change previously (the music configuration menu). I have a bit of time in the coming days, so I promise to check that soon this time! Sorry for the delay

@Anoaxx
Copy link
Author

Anoaxx commented Dec 2, 2023

As u said last time: you wanted to finish GUI before that, and i notice u made an update with config options

@charlyb01
Copy link
Member

I spent quite a lot of time trying to find what was stopping the sound when joining a world, but sadly I didn't find. This is likely not trivial, or maybe I just missed something. I will stop searching for now, as it should not take this much time for a simple feature.
However, I added an option to not pause music when we pause the game. That's at least one part of your request. I will release a new version including this shortly.

charlyb01 added a commit that referenced this issue Dec 6, 2023
Whenever we try to pause all sounds, do not pause music category sounds. In vanilla, this is the same as "when opening game menu, don't pause music"
@charlyb01
Copy link
Member

I released a new version with the option to not pause music in the game menu. Don't hesitate to try it out!

@alien-sunset
Copy link

i know this issue seems to be a bit bigger than it initially looked, so don't feel rushed, but I just wanted to pop in a and say that I also would like the music to not stop when joining a world or when i go through portals

@Anoaxx
Copy link
Author

Anoaxx commented Apr 11, 2024

i mean part of it should be in.. music in pause menu is already in, but probably its going to be rewrited?

@charlyb01
Copy link
Member

I didn't find how to not stop the music when joining a world at that time. I may investigate a bit more to find a solution, but as I spent already quite a lot of time for this "small" feature, I don't want to spend too much time on it.

For the portals, I think it might be linked to the same issue when joining a world. I will check again soon and get back to you to tell you if I found a way or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants