improvement

sethsandaru · Apr 20, 2024 · 5b30f0b · 5b30f0b
1 parent ba416d8
commit 5b30f0b
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/Services/Generators/ColumnsGenerator.php b/src/Services/Generators/ColumnsGenerator.php
@@ -80,7 +80,7 @@ protected function resolveColumnType(Column $column): string
         return $type;
     }
 
-    protected function getDateCasting(string $column): bool
+    protected function getDateCasting(string $column): string
     {
         if (in_array($column, ['created_at', 'updated_at', 'deleted_at'])) {
             return Carbon::class;

diff --git a/tests/Units/Generators/PropertyGeneratorTest.php b/tests/Units/Generators/PropertyGeneratorTest.php
@@ -84,4 +84,38 @@ public function testNumericPostgresRenderFloat()
 
         $this->assertStringContainsString('@property float $number', $generatedText);
     }
+
+    public function testDatesCastColumns()
+    {
+        Schema::create('test_date_columns_table', function (Blueprint $table) {
+            $table->timestamps();
+            $table->softDeletes();
+            $table->timestamp('activated_at');
+            $table->timestamp('enabled_at');
+            $table->timestamp('no_cast_at')->nullable();
+            $table->date('incurred_date')->nullable();
+            $table->date('invoiced_date');
+        });
+
+        $columnGenerator = app(ColumnsGenerator::class);
+        $generatedText = $columnGenerator->generate(new class extends Model {
+            protected $table = 'test_date_columns_table';
+
+            protected $casts = [
+                'incurred_date' => 'date',
+                'activated_at' => 'datetime',
+                'invoiced_date' => 'immutable_date',
+                'enabled_at' => 'immutable_datetime',
+            ];
+        });
+
+        $this->assertStringContainsString('@property Carbon\Carbon|null $created_at', $generatedText);
+        $this->assertStringContainsString('@property Carbon\Carbon|null $updated_at', $generatedText);
+        $this->assertStringContainsString('@property Carbon\Carbon|null $deleted_at', $generatedText);
+        $this->assertStringContainsString('@property Carbon\Carbon $activated_at', $generatedText);
+        $this->assertStringContainsString('@property Carbon\CarbonImmutable $enabled_at', $generatedText);
+        $this->assertStringContainsString('@property string|null $no_cast_at', $generatedText);
+        $this->assertStringContainsString('@property Carbon\Carbon|null $incurred_date', $generatedText);
+        $this->assertStringContainsString('@property Carbon\CarbonImmutable $invoiced_date', $generatedText);
+    }
 }