Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix clippy errors on main #1019

Merged
merged 4 commits into from
Feb 4, 2025
Merged

chore: fix clippy errors on main #1019

merged 4 commits into from
Feb 4, 2025

Conversation

dsherret
Copy link
Contributor

No description provided.

@dsherret dsherret mentioned this pull request Jan 27, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@84cf467). Learn more about missing BASE report.

Files with missing lines Patch % Lines
url/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage        ?   80.44%           
=======================================
  Files           ?       24           
  Lines           ?     4225           
  Branches        ?        0           
=======================================
  Hits            ?     3399           
  Misses          ?      826           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lucacasonato
lucacasonato approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato added this pull request to the merge queue Feb 4, 2025
Merged via the queue into servo:main with commit ffca1ef Feb 4, 2025
18 checks passed
@dsherret dsherret deleted the chore_fix_clippy branch February 4, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @Manishearth @lucacasonato