Fixed invalid testnet case

sergey0xff · Jan 10, 2020 · 1a6fed1 · 1a6fed1
1 parent 3e0ce75
commit 1a6fed1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/btc_validator/__init__.py b/btc_validator/__init__.py
@@ -184,7 +184,10 @@ def is_valid_btc_address(
             ):
                 return False
 
-        h = _base58_decode(address)
+        try:
+            h = _base58_decode(address)
+        except ValueError:
+            return False
 
         if len(h) != 25:
             return False

diff --git a/test_btc_validator.py b/test_btc_validator.py
@@ -36,7 +36,8 @@ def test_testnet_address(btc_address):
         '',
         'tb1qw508d6qejxtdg4y5r3zarvary0c5xw7kxpjz',
         'tb1508d6qejxtdg4y5r3zarvary0c5xw7kxpjzsx',
-        'bc1qrp33g0q5c5txsp9arysrx4k6zdk5s4nce4xj0gdcccefvpysxf3qccfmv3'
+        'bc1qrp33g0q5c5txsp9arysrx4k6zdk5s4nce4xj0gdcccefvpysxf3qccfmv3',
+        '1A1z[1eP5QGefi2DMPTfTL5SLmv7DivfNa',
     ]
 )
 @pytest.mark.parametrize(