Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve BestpathCount bug with PASS #1615

Merged
merged 12 commits into from
Nov 4, 2023

Conversation

sensuikan1973
Copy link
Owner

@sensuikan1973 sensuikan1973 commented Oct 29, 2023

resolve #1614

@sensuikan1973
Copy link
Owner Author

sensuikan1973 commented Oct 29, 2023

F5d6C3d3C4f4F6f3E6e7F7c5B6g6G5c6E8b5E3d2B3h4D7b4A5a4A3a6F2g4A7c7D8g3H6f1H5c8B8g8B7g7C2f8H8h7E1d1G2e2H3h1H2c1b1

image

great

@sensuikan1973
Copy link
Owner Author

sensuikan1973 commented Oct 29, 2023

image oh...

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #1615 (330a1ef) into main (78b3849) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
- Coverage   94.67%   94.62%   -0.05%     
==========================================
  Files          52       52              
  Lines        1503     1508       +5     
==========================================
+ Hits         1423     1427       +4     
- Misses         80       81       +1     
Flag Coverage Δ
integration_test 70.82% <0.00%> (-0.31%) ⬇️
macos 92.90% <72.72%> (+2.08%) ⬆️
ubuntu 93.43% <72.72%> (-0.18%) ⬇️
widget_test 90.92% <72.72%> (+0.16%) ⬆️
windows 93.96% <72.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/board/pedax_board.dart 97.56% <66.66%> (-0.83%) ⬇️
lib/engine/api/count_bestpath.dart 80.76% <75.00%> (-4.24%) ⬇️

... and 3 files with indirect coverage changes

…ons` (#1621)

Co-authored-by: sensuikan1973 <sensuikan1973@users.noreply.github.com>
sensuikan1973 and others added 7 commits November 4, 2023 20:24
…ons` (#1622)

Co-authored-by: sensuikan1973 <sensuikan1973@users.noreply.github.com>
…ons` (#1623)

Co-authored-by: sensuikan1973 <sensuikan1973@users.noreply.github.com>
@sensuikan1973 sensuikan1973 enabled auto-merge (squash) November 4, 2023 17:16
@sensuikan1973 sensuikan1973 merged commit 6dd1ffd into main Nov 4, 2023
18 checks passed
@sensuikan1973 sensuikan1973 deleted the fix_bug_bestpathcount_with_pass branch November 4, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show wrong BestpathCount when future positions include PASS
2 participants