Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/mwi: fixing problems from issue #56 #57

Closed
wants to merge 1 commit into from

Conversation

dunst0
Copy link
Contributor

@dunst0 dunst0 commented Mar 23, 2017

As mentioned in issue #56

@nwhitehorn
Copy link
Contributor

This would be great to have in. Any chance of merging?

@juha-h
Copy link
Contributor

juha-h commented Mar 28, 2019

the tittle is "fixing problems fro issue #56", but this pull requests appears to do more that that, e.g., it introduces a new config file. the confit file allows choosing if presence server is used. if there is no presence server, then there cannot be a publish reuest and the app should itself haldle also subcriptions and issue notifies. so i'm confused what this pull request is all about.

@nwhitehorn
Copy link
Contributor

Yes, there is unfortunately some extraneous stuff. The main thing is that, with a presence server, I think it needs to do PUBLISH and not NOTIFY (I am not a SIP expert, but NOTIFY didn't work for me and I had to patch SEMS to working MWI) and the current code unconditionally does NOTIFY. With the patch, it unconditionally does PUBLISH. Maybe that is not the right thing either and it needs to be conditional?

@juha-h
Copy link
Contributor

juha-h commented Apr 6, 2019 via email

@juha-h
Copy link
Contributor

juha-h commented Apr 7, 2019

Waiting for new pull request.

@juha-h juha-h closed this Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants