Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: templating of path #630

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat: templating of path #630

merged 2 commits into from
Nov 15, 2023

Conversation

mattyclarkson
Copy link
Contributor

Runs Lodash templating on the asset path.

@fgreinacher
Copy link
Contributor

Thanks @mattyclarkson! The change looks good! Please update the relevant readme chapter and add a test case that verifies the templating works and we can get this in 🙇

@mattyclarkson
Copy link
Contributor Author

Thanks @mattyclarkson! The change looks good! Please update the relevant readme chapter and add a test case that verifies the templating works and we can get this in 🙇

Done ✔️ Hope it is enough test coverage!

@mattyclarkson
Copy link
Contributor Author

mattyclarkson commented Nov 15, 2023

Ooo, will fix up the test failures. Have switched to re-using the upload.txt to prevent churn in other tests.

Runs Lodash templating on the asset path.
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fgreinacher fgreinacher merged commit 18d09c2 into semantic-release:master Nov 15, 2023
8 checks passed
Copy link

🎉 This PR is included in version 12.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mattyclarkson mattyclarkson deleted the patch-1 branch November 16, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants