Fix pre-commit configuration for gersemi #1670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egecetin
changed the title
egecetin
commented
Dec 25, 2024
| @@ -41,6 +41,7 @@ repos: | |||
| rev: 0.17.1 | |||
| hooks: | |||
| - id: gersemi | |||
| args: ["-c"] | |||
There was a problem hiding this comment.
This ensures that gersemi run in check mode which returns 1 if any formatting required and 0 otherwise
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1670 +/- ##
=======================================
Coverage 83.15% 83.16%
=======================================
Files 277 277
Lines 48193 48193
Branches 9949 9966 +17
=======================================
+ Hits 40074 40078 +4
+ Misses 7226 7220 -6
- Partials 893 895 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all txt files are excluded which prevents fixing of CMake files (which not noticed by me in #1602 unfortunately). This PR should fix this issue