Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat Packet++ documentation to use triple-slash doxygen format. #1659

Merged
merged 23 commits into from
Feb 3, 2025

Conversation

Dimi1010
Copy link
Collaborator

Part of #1658
Includes reformatting of classes, structs and namespace documentation.

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (2ae8837) to head (7705b5a).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1659      +/-   ##
==========================================
+ Coverage   83.13%   83.58%   +0.45%     
==========================================
  Files         279      275       -4     
  Lines       48395    47762     -633     
  Branches    10500    10101     -399     
==========================================
- Hits        40231    39922     -309     
+ Misses       7044     6786     -258     
+ Partials     1120     1054      -66     
Flag Coverage Δ
alpine320 75.09% <ø> (-0.01%) ⬇️
fedora40 75.12% <ø> (-0.04%) ⬇️
macos-13 80.61% <ø> (+<0.01%) ⬆️
macos-14 80.61% <ø> (+<0.01%) ⬆️
macos-15 80.58% <ø> (ø)
mingw32 70.80% <ø> (-0.04%) ⬇️
mingw64 70.79% <ø> (-0.02%) ⬇️
npcap 85.21% <ø> (-0.02%) ⬇️
rhel94 75.01% <ø> (+0.03%) ⬆️
ubuntu2004 58.62% <ø> (+0.03%) ⬆️
ubuntu2004-zstd 58.71% <ø> (+<0.01%) ⬆️
ubuntu2204 74.89% <ø> (-0.01%) ⬇️
ubuntu2204-icpx 61.27% <ø> (ø)
ubuntu2404 75.13% <ø> (-0.04%) ⬇️
unittest 83.58% <ø> (+0.45%) ⬆️
windows-2019 85.24% <ø> (-0.01%) ⬇️
windows-2022 85.27% <ø> (-0.01%) ⬇️
winpcap 85.24% <ø> (ø)
xdp ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PS: Formatting ASCII drawings is annoying.
PS: Formating ASCII Drawings.
@Dimi1010 Dimi1010 force-pushed the refactor/triple-slash-docs-packet branch from 31cf265 to 3cc0e7c Compare December 17, 2024 06:50
@Dimi1010 Dimi1010 force-pushed the refactor/triple-slash-docs-packet branch from a28a062 to 8d2a6e3 Compare January 9, 2025 20:13
@Dimi1010 Dimi1010 force-pushed the refactor/triple-slash-docs-packet branch from 8d2a6e3 to 87ff355 Compare January 9, 2025 20:15
@Dimi1010
Copy link
Collaborator Author

Dimi1010 commented Jan 9, 2025

Ok, minor issue with the reformatting.
There are some @verbatim blocks that don't like working well with the /// format, and I am not sure how to deal with that...
The issues are that I am unsure if the /// will show in the actual verbatim text and the /// block needs to be unbroken with those lines to count as a single block. Also, I am getting a parser error in the SSLLayer so the parser may also be getting confused.

So unless anyone has ideas, I guess, we have 3 options.

cc: @seladb @tigercosmos

This was referenced Jan 17, 2025
@Dimi1010
Copy link
Collaborator Author

Dimi1010 commented Jan 17, 2025

Discontinued due to issues with doxygen parsing of verbatim example blocks.

@Dimi1010 Dimi1010 closed this Jan 17, 2025
@Dimi1010 Dimi1010 reopened this Jan 18, 2025
@Dimi1010 Dimi1010 force-pushed the refactor/triple-slash-docs-packet branch from 785d2cb to fc84dc9 Compare January 18, 2025 21:44
@Dimi1010
Copy link
Collaborator Author

Fix seems to work. Thanks @egecetin .

@Dimi1010 Dimi1010 marked this pull request as ready for review January 19, 2025 07:10
@Dimi1010 Dimi1010 requested a review from seladb as a code owner January 19, 2025 07:10
@tigercosmos tigercosmos merged commit 66ccbe8 into seladb:dev Feb 3, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants