Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-tidy fixes for Common++ #1639

Merged
merged 29 commits into from
Jan 12, 2025

format

e5d28d6
Select commit
Loading
Failed to load commit list.
Merged

Clang-tidy fixes for Common++ #1639

format
e5d28d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 11, 2025 in 0s

83.11% (+0.56%) compared to bc5c08d

View this Pull Request on Codecov

83.11% (+0.56%) compared to bc5c08d

Details

Codecov Report

Attention: Patch coverage is 75.70621% with 43 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (bc5c08d) to head (e5d28d6).

Files with missing lines Patch % Lines
Common++/src/Logger.cpp 16.66% 15 Missing ⚠️
Common++/src/SystemUtils.cpp 66.66% 7 Missing ⚠️
Common++/src/IpUtils.cpp 70.58% 3 Missing and 2 partials ⚠️
...ples/IcmpFileTransfer/IcmpFileTransfer-pitcher.cpp 0.00% 3 Missing ⚠️
Common++/src/IpAddress.cpp 93.54% 2 Missing ⚠️
Common++/src/OUILookup.cpp 77.77% 1 Missing and 1 partial ⚠️
Examples/ArpSpoofing/main.cpp 0.00% 2 Missing ⚠️
Common++/src/GeneralUtils.cpp 80.00% 1 Missing ⚠️
Common++/src/MacAddress.cpp 75.00% 0 Missing and 1 partial ⚠️
Examples/DnsSpoofing/main.cpp 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1639      +/-   ##
==========================================
+ Coverage   82.54%   83.11%   +0.56%     
==========================================
  Files         277      277              
  Lines       48081    48207     +126     
  Branches     9341     9913     +572     
==========================================
+ Hits        39688    40066     +378     
+ Misses       7491     7248     -243     
+ Partials      902      893       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov