Remove deprecated TcpOptionType #1615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1615 +/- ##
==========================================
- Coverage 83.16% 83.14% -0.03%
==========================================
Files 276 276
Lines 47288 47191 -97
Branches 9616 9498 -118
==========================================
- Hits 39326 39235 -91
+ Misses 7076 7072 -4
+ Partials 886 884 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| .isNotNull()); | ||
| tcpLayer.addTcpOption(pcpp::TcpOptionBuilder(pcpp::TcpOptionBuilder::NopEolOptionEnumType::Nop)).isNotNull()); | ||
| PTF_ASSERT_EQUAL(tcpLayer.getHeaderLen(), 24); | ||
| PTF_ASSERT_TRUE(tcpLayer |
There was a problem hiding this comment.
The formatting looks bad here. Maybe turn off clang-format here?
|
@WojtekMs I think we might want to remove this in future versions |
clementperon
added
the
breaking change
|
Okay, so for now, maybe I will close this PR? |
I think its fine to keep it open, as a reminder. |
|
I put it in the milestone, so we don't forget it. |
|
We can either leave it open or close it, I don't have a strong opinion |
This is a continuation of #1289
Please let me know if you think it's okay to remove the deprecated feature, now that it was already released :)