Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate shared DeviceList functionality under a common base class. #1488

Open
wants to merge 90 commits into
base: dev
Choose a base branch
from

Lint

b58284b
Select commit
Loading
Failed to load commit list.
Open

Consolidate shared DeviceList functionality under a common base class. #1488

Lint
b58284b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 5, 2025 in 0s

83.24% (+0.08%) compared to 7898a5d

View this Pull Request on Codecov

83.24% (+0.08%) compared to 7898a5d

Details

Codecov Report

Attention: Patch coverage is 74.14634% with 53 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (7898a5d) to head (b58284b).

Files with missing lines Patch % Lines
Pcap++/src/PcapRemoteDeviceList.cpp 0.00% 22 Missing ⚠️
Pcap++/src/PcapLiveDeviceList.cpp 79.41% 7 Missing ⚠️
Common++/header/PointerVector.h 60.00% 2 Missing ⚠️
Examples/DnsSpoofing/main.cpp 0.00% 2 Missing ⚠️
Examples/HttpAnalyzer/main.cpp 0.00% 2 Missing ⚠️
Examples/IcmpFileTransfer/Common.cpp 0.00% 2 Missing ⚠️
...ples/IcmpFileTransfer/IcmpFileTransfer-catcher.cpp 0.00% 2 Missing ⚠️
...ples/IcmpFileTransfer/IcmpFileTransfer-pitcher.cpp 0.00% 2 Missing ⚠️
Examples/SSLAnalyzer/main.cpp 0.00% 2 Missing ⚠️
Examples/TLSFingerprinting/main.cpp 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1488      +/-   ##
==========================================
+ Coverage   83.16%   83.24%   +0.08%     
==========================================
  Files         277      279       +2     
  Lines       48201    48250      +49     
  Branches     9932     9968      +36     
==========================================
+ Hits        40086    40168      +82     
+ Misses       7266     7210      -56     
- Partials      849      872      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov