Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos #200

Merged
merged 2 commits into from
Jan 12, 2025
Merged

fix: typos #200

merged 2 commits into from
Jan 12, 2025

Conversation

yash251
Copy link
Contributor

@yash251 yash251 commented Jan 11, 2025

What is the purpose of the change?

correct existing documentation

Describe the changes to the documentation

fix typos across the repo

@yash251 yash251 requested a review from a team as a code owner January 11, 2025 09:51
alexander-sei
alexander-sei approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@alexander-sei alexander-sei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cordt-sei
cordt-sei previously requested changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@cordt-sei cordt-sei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything referencing the Dex module is obsolete and shouid be removed.

@yash251
Copy link
Contributor Author

yash251 commented Jan 12, 2025

pages/seid/query/dex.md and pages/seid/query/dex/get-order-count.md do you want me to delete these files entirely?

@alexander-sei
Copy link
Collaborator

pages/seid/query/dex.md and pages/seid/query/dex/get-order-count.md do you want me to delete these files entirely?
@yash251 yes please :)

@alexander-sei alexander-sei self-requested a review January 12, 2025 13:15
alexander-sei
alexander-sei approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@alexander-sei alexander-sei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexander-sei alexander-sei merged commit 232dfc4 into sei-protocol:main Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-sei alexander-sei alexander-sei approved these changes

@cordt-sei cordt-sei Awaiting requested review from cordt-sei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash251 @alexander-sei @cordt-sei