fixed missing row issues due to skipping heade row in each page of responses(#12) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'd rather test against the real AWS API instead of mocks if it's convenient since that's what we've been doing so far, and it's what matters in the end. How many results does it take to hit a new page? Is it a static amount? |
|
The default page size is 1000 i think. Unfortunately i don't have a test account for aws, this issue came up when trying to run some queries in my workplace, and i can't share the query or the data. so mocking seemed the easier way. please suggest some way to test it. thanks. |
|
@nfssdq Got it. We need CI haha so only integration tests can be reasonably accepted. Anyhow, mocks are OK here. Merging. Thanks! |
|
Thanks a lot for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in #12 . I didn't fix the issue #10 . However i have put a SkipHeaderRow field in the config which can be used to signal if it should skip the first row of the first response page. But whatever happens the first row of the subsequent pages of the query response are not skipped.