Merge pull request #33 from securenative/dev

Fix multi-value headers
securenative · Oct 28, 2020 · caad62f · caad62f
2 parents a5dcfd0 + 29dafa4
commit caad62f
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    securenative (0.1.38)
+    securenative (0.1.39)
 
 GEM
   remote: https://rubygems.org/

diff --git a/lib/securenative/utils/request_utils.rb b/lib/securenative/utils/request_utils.rb
@@ -50,7 +50,7 @@ def self.get_client_ip_from_request(request, options)
         begin
           header_value = request.env['HTTP_X_FORWARDED_FOR']
           if header_value.include? ','
-            header_value = ip.split(',')[0]
+            header_value = header_value.split(',')[0]
           end
           if self.validate_ip(header_value)
             return header_value
@@ -59,7 +59,7 @@ def self.get_client_ip_from_request(request, options)
           begin
             header_value = request['HTTP_X_FORWARDED_FOR']
             if header_value.include? ','
-              header_value = ip.split(',')[0]
+              header_value = header_value.split(',')[0]
             end
             if self.validate_ip(header_value)
               return header_value
@@ -72,7 +72,7 @@ def self.get_client_ip_from_request(request, options)
         begin
           header_value = request.env['HTTP_X_REAL_IP']
           if header_value.include? ','
-            header_value = ip.split(',')[0]
+            header_value = header_value.split(',')[0]
           end
           if self.validate_ip(header_value)
             return header
@@ -81,7 +81,7 @@ def self.get_client_ip_from_request(request, options)
           begin
             header_value = request['HTTP_X_REAL_IP']
             if header_value.include? ','
-              header_value = ip.split(',')[0]
+              header_value = header_value.split(',')[0]
             end
             if self.validate_ip(header_value)
               return header_value
@@ -94,7 +94,7 @@ def self.get_client_ip_from_request(request, options)
         begin
           header_value = request.env['REMOTE_ADDR']
           if header_value.include? ','
-            header_value = ip.split(',')[0]
+            header_value = header_value.split(',')[0]
           end
           if self.validate_ip(header_value)
             return header_value
@@ -103,7 +103,7 @@ def self.get_client_ip_from_request(request, options)
           begin
             header_value = request['REMOTE_ADDR']
             if header_value.include? ','
-              header_value = ip.split(',')[0]
+              header_value = header_value.split(',')[0]
             end
             if self.validate_ip(header_value)
               return header_value

diff --git a/lib/securenative/version.rb b/lib/securenative/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SecureNative
-  VERSION = '0.1.38'
+  VERSION = '0.1.39'
 end
diff --git a/spec/securenative/spec_api_manager.rb b/spec/securenative/spec_api_manager.rb
@@ -55,7 +55,7 @@
         'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
         'Authorization' => 'YOUR_API_KEY',
         'Content-Type' => 'application/json',
-        'Sn-Version' => '0.1.38',
+        'Sn-Version' => '0.1.39',
         'User-Agent' => 'SecureNative-ruby'
       }
     ).to_return(status: 200, body: '', headers: {})

diff --git a/spec/securenative/spec_event_manager.rb b/spec/securenative/spec_event_manager.rb
@@ -29,7 +29,7 @@ def initialize
               'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
               'Authorization' => 'YOUR_API_KEY',
               'Content-Type' => 'application/json',
-              'Sn-Version' => '0.1.38',
+              'Sn-Version' => '0.1.39',
               'User-Agent' => 'SecureNative-ruby'
             })
       .to_return(status: 200, body: '', headers: {})
@@ -53,7 +53,7 @@ def initialize
               'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
               'Authorization' => 'YOUR_API_KEY',
               'Content-Type' => 'application/json',
-              'Sn-Version' => '0.1.38',
+              'Sn-Version' => '0.1.39',
               'User-Agent' => 'SecureNative-ruby'
             })
       .to_return(status: 401, body: '', headers: {})
@@ -74,7 +74,7 @@ def initialize
               'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
               'Authorization' => 'YOUR_API_KEY',
               'Content-Type' => 'application/json',
-              'Sn-Version' => '0.1.38',
+              'Sn-Version' => '0.1.39',
               'User-Agent' => 'SecureNative-ruby'
             })
       .to_return(status: 500, body: '', headers: {})

diff --git a/spec/securenative/spec_http_client.rb b/spec/securenative/spec_http_client.rb
@@ -15,7 +15,7 @@
               'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
               'Authorization' => 'YOUR_API_KEY',
               'Content-Type' => 'application/json',
-              'Sn-Version' => '0.1.38',
+              'Sn-Version' => '0.1.39',
               'User-Agent' => 'SecureNative-ruby'
             }).to_return(status: 200, body: '', headers: {})