Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dataset_len error message #879

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Improve dataset_len error message #879

merged 1 commit into from
Oct 9, 2024

Conversation

uri-granta
Copy link
Collaborator

Related issue(s)/PRs:

Summary

...

Fully backwards compatible: yes / no

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

avullo
avullo approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@avullo avullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uri-granta uri-granta merged commit 1a2e0ac into develop Oct 9, 2024
12 checks passed
@uri-granta uri-granta deleted the uri/quickfix/better_dataset_len_exception branch October 9, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avullo avullo avullo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @avullo