Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tags assert in filter_datasets #855

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix tags assert in filter_datasets #855

merged 1 commit into from
Jun 10, 2024

Conversation

khurram-ghani
Copy link
Collaborator

Related issue(s)/PRs: None

Summary

Fix missing conversion to tuple in filter_datasets assertion.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

uri-granta
uri-granta approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks. I wonder whether pylint could have caught this as a code smell (comparing a Sequence to an Optional[Tuple]).

@khurram-ghani khurram-ghani merged commit 7a595dc into develop Jun 10, 2024
12 checks passed
@khurram-ghani khurram-ghani deleted the khurram/fix_tags_assert branch June 10, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-granta uri-granta uri-granta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khurram-ghani @uri-granta