Search spaces should be deepcopied #776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs: #104
Summary
Search spaces are currently not deepcopied for speed reasons (see #104). However, since there's nothing in the search space API that says spaces must be immutable this can result in bugs. It's also not clear how significant the speed saving is (saving state is not usually a bottleneck).
Fully backwards compatible: yes
PR checklist