Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobuild happily accepts multiple declarations of the same 3P. #44

Open
Nicky-D opened this issue Apr 2, 2024 · 1 comment
Open

autobuild happily accepts multiple declarations of the same 3P. #44

Nicky-D opened this issue Apr 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Nicky-D
Copy link

Nicky-D commented Apr 2, 2024

For example here I did catch a double of meshoptimizer (linux64). I suppose those come through merges and autobuild then latter happily accepts such a file. Either pulling the first or last.
Here is another one I found today Nicky-D/viewer@043a13b

autobuild should at least warn if there is multiple (conflicting) definitions of one 3P

@nat-goodspeed
Copy link
Contributor

Seems like this would be a fix in python-llsd deserialization: detecting duplicate serialized map keys. By the time autobuild sees the data, there are no duplicate keys because one of them has already overwritten the other.

@bennettgoble bennettgoble changed the title autobuild happily accpets multiple declarations of the same 3P. autobuild happily accepts multiple declarations of the same 3P. Apr 4, 2024
@bennettgoble bennettgoble added the bug Something isn't working label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants