Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory() unify RAM manufacturers and include Windows to parse #962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tellinq
Copy link

@Tellinq Tellinq commented Jan 18, 2025

  1. Devices that use hex-based identification can use Windows, such as MacBooks.
  2. The OSX and Linux RAM manufacturer list are redundant, which can and should be unified.

I opted to use the manufacturer parsing done for Linux as that method has a higher chance of catching applicable manufacturers/

An example output from my MacBook Pro 2013 on Windows 11 24H2:

Before

"memLayout": [
    {
      "size": 4294967296,
      "bank": "BANK 0/0",
      "type": "DDR3",
      "ecc": false,
      "clockSpeed": 1600,
      "formFactor": "SODIMM",
      "manufacturer": "0x02FE",
      "partNum": "0x45424A3431554638424455302D474E2D4620",
      "serialNum": "0",
      "voltageConfigured": 0,
      "voltageMin": 0,
      "voltageMax": 0
    },
    {
      "size": 4294967296,
      "bank": "BANK 1/1",
      "type": "DDR3",
      "ecc": false,
      "clockSpeed": 1600,
      "formFactor": "SODIMM",
      "manufacturer": "0x02FE",
      "partNum": "0x45424A3431554638424455302D474E2D4620",
      "serialNum": "0",
      "voltageConfigured": 0,
      "voltageMin": 0,
      "voltageMax": 0
    }
  ],

After

"memLayout": [
    {
      "size": 4294967296,
      "bank": "BANK 0/0",
      "type": "DDR3",
      "ecc": false,
      "clockSpeed": 1600,
      "formFactor": "SODIMM",
      "manufacturer": "Elpida",
      "partNum": "0x45424A3431554638424455302D474E2D4620",
      "serialNum": "0",
      "voltageConfigured": 0,
      "voltageMin": 0,
      "voltageMax": 0
    },
    {
      "size": 4294967296,
      "bank": "BANK 1/1",
      "type": "DDR3",
      "ecc": false,
      "clockSpeed": 1600,
      "formFactor": "SODIMM",
      "manufacturer": "Elpida",
      "partNum": "0x45424A3431554638424455302D474E2D4620",
      "serialNum": "0",
      "voltageConfigured": 0,
      "voltageMin": 0,
      "voltageMax": 0
    }
  ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant