Fix: Small fixes 11/22 #642
Conversation
| { | ||
| transaction.Rollback(); | ||
| connection.Close(); |
There was a problem hiding this comment.
Why don't we need to close the connection here?
There was a problem hiding this comment.
Because it's closed in the finally, which will execute automatically when you leave the scope of the try-catch.
| @@ -950,7 +950,7 @@ public PacketQueue HandleEnemyHuntRequests(Enemy enemy, DbConnection? connection | |||
|
|
|||
| S2CQuestQuestProgressWorkSaveNtc ntc = new() | |||
| { | |||
| QuestScheduleId = quest.Key, | |||
| QuestScheduleId = questScheduleId, | |||
There was a problem hiding this comment.
This is just a syntax change to make the iteration more explicit, not a functional one.
There was a problem hiding this comment.
Key and schedule id are two different values. I could never figure out what key value was based on and it is left as zero generally.
There was a problem hiding this comment.
No, in this case, quest is/was the KeyValuePair<uint, QuestState> that's returned by iterating over ActiveQuests, and that uint is actually the QuestScheduleId (see line 205). So quest.Key is not the Key field of a Quest object, but the Key field of a KeyValuePair<uint, QuestState>.
… floating around; just skip them instead.
…ate properly when thrown during a transaction.
…her than their visual gear where applicable.
RyanYappert
force-pushed
the
fix/fixes-11-22
branch
from
d9672ae to
a0a23bd
Compare
FriendApplyFriendHandlerdue to a missing constructor.QuestGetMainQuestListHandlerdue to invalid scheduleIds.ProfileGetCharacterProfileHandlerdue to invalid characterIds.InstanceEnemyKillHandler, maybe???RequestPacketHandlerandResponseErrorExceptionExecuteInTransactionno longer mangle their stack trace.ResponseErrorExceptions thrown duringExecuteInTransactionproperly propagate and will send the error response packet to the client.ResponseErrorExceptions thrown fromRequestPacketHandlers log the first line of their stack trace, in case we want to track it down later.Checklist:
developbranch