Improve Statistics modal
#354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in cases when we add a lot of new languages in bulk. We could have also modified the service method or REST API endpoint, but I have no idea if we might end up needing the original behaviour for something else. Ergo, the filtering is left up to the presentation layer.
Changed the shape and color of the box shadow when the close button is focused.
Since it resides in the table body, it will be automatically replaced once the statistics are fetched from the server.
Unlike the table, this one required some additional JavaScript to toggle visibility properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present state of the modal has made it difficult to read on small devices. This PR adds a table to the statistics presentation, which is easier to read on smaller screens. Includes a plethora of quality-of-life improvements, such as separate panes for each visualisation, multiple export options and loading states.