Fixes Issue #1113: TLS: Ignore certs in pem file when loading private key #1114
+20
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ignores just certs in the file. Options I considered:
Ignore all the non-key items. replacing with
_ => {},
Ignore explicitly the existing entries in
rustls_pemfile::Item::*
that are not a key. replacing withrustls_pemfile::Item::X509Certificate(_) | Crl(_) | Csr(_) => {},
Ignore just the certs
X509Certificate(_) => {}, _ => return Err(TlsConfigError::UnknownPrivateKeyFormat),
Any of those would resolve my issue of certs + keys in same file, happy to adjust diff as needed.