Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP retries #108

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Support HTTP retries #108

merged 11 commits into from
Jul 15, 2024

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Jul 3, 2024

Closes #96

@andrii-balitskyi andrii-balitskyi requested a review from razor-x July 3, 2024 16:46
@andrii-balitskyi andrii-balitskyi requested a review from razor-x July 12, 2024 11:00
@andrii-balitskyi
Copy link
Contributor Author

@razor-x Are we good to merge this?

@razor-x
Copy link
Member

razor-x commented Jul 12, 2024

@andrii-balitskyi I think it's ok to merge. I'm happy to keep Retry() as the default for now, but the other default seems ok.

Main issue is that we don't have a test, but in order to test this we would need to use seam.client anyway since Retry won't ever trigger on POST.

Let's revisit this when we have preferred method and semantic method in the blueprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support HTTP retries
3 participants