Introduce analogue clock time icon #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecosaur
force-pushed
the
master
branch
2 times, most recently
from
e742ed7 to
661a448
Compare
|
Following a suggestion from @elken, the |
seagle0128
reviewed
Mar 7, 2024
With the SVG library (bundled as part of Emacs), we can generate an analogue clock for the current time to-the-minute, instead of using the nearest-hour nerdicon. This relies on a graphical display, and so a new variable is introduced, `doom-modeline-time-analogue-clock' and the behaviour is gated on (display-graphic-p). There are a number of variables that affect the style of the displayed clock. For now, I've chosen to be conservative and just expose `doom-modeline-time-clock-minute-resolution' as a custom variable, leaving the rest as constants. We may well want to revisit this in the future. I've personally been running this variant of the time segment for over a year now, and as a result am pretty confident there are no behaviour or performance issues with this implementation. This implementation is originally sourced from https://github.com/tecosaur/emacs-config/blob/a3c3b73a00f4e034ffeae11f20b00d1eb948a6e6/config.org#time.
|
Thank you! |
seagle0128
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the SVG library (bundled as part of Emacs), we can generate an analogue clock for the current time to-the-minute, instead of using the nearest-hour nerdicon.
I've personally been running this variant of the time segment since #577 (comment), and so am pretty confident this works as we'd hope.
The one thing I wonder about is whether we can make the
svglibrary be required only whendoom-modeline--generate-clockis first called?Sample screenshot:
