elfloader: Add generic-timer driver #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kent-mcleod
force-pushed
the
kent/elfloader
branch
from
b0c2581 to
e60b398
Compare
|
I wonder, do we want keep the empty |
axel-h
reviewed
May 30, 2023
axel-h
reviewed
May 30, 2023
axel-h
reviewed
May 30, 2023
axel-h
reviewed
May 30, 2023
If possible we want to support platforms without having to add empty files for each one |
kent-mcleod
force-pushed
the
kent/elfloader
branch
from
e60b398 to
03206bd
Compare
kent-mcleod
force-pushed
the
kent/elfloader
branch
7 times, most recently
from
9449166 to
b318dd0
Compare
Indanz
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Overall a good improvement.
I think merging this without also merging seL4/seL4#1047 will break things, so both need to be used together.
kent-mcleod
force-pushed
the
kent/elfloader
branch
2 times, most recently
from
e3d0927 to
b70ec4a
Compare
axel-h
reviewed
Feb 15, 2024
axel-h
reviewed
Feb 15, 2024
lsf37
approved these changes
Feb 15, 2024
Indanz
approved these changes
Feb 16, 2024
This is to support core-specific driver init handling. Signed-off-by: Kent McLeod <kent@kry10.com>
This driver just sets CNTVOFF_El2 to 0 if possible. This can only be done if the elfloader is in hyp-mode, otherwise nothing happens. Signed-off-by: Kent McLeod <kent@kry10.com>
These calls can now be implemented via binding the /timer driver in the elfloader's device tree configuration (located in the kernel's platform directory). Signed-off-by: Kent McLeod <kent@kry10.com>
RISC-V platforms don't use any extension drivers currently so it's not useful to compile and link them in when not building for arm. Signed-off-by: Kent McLeod <kent@kry10.com>
This was previously added to handle per-core initialization of the generic timer. Now that a generic driver mechanism is used to perform this initialization the old interface is redundant. Signed-off-by: Kent McLeod <kent@kry10.com>
Device initialization returns early if an error is encountered. Handle this error by printing an Error message and aborting the booting process. Signed-off-by: Kent McLeod <kent@kry10.com>
kent-mcleod
force-pushed
the
kent/elfloader
branch
from
b70ec4a to
6dae789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This driver just sets CNTVOFF_El2 to 0 if possible.
This can only be done if the elfloader is in hyp-mode, otherwise nothing
happens.
This allows us to replace most of the platform-specific code in the elfloader.
This originally came up with #73 (comment)