Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(io): simplify resource interface #93

Merged
merged 8 commits into from
Oct 20, 2023
Merged

refactor(io): simplify resource interface #93

merged 8 commits into from
Oct 20, 2023

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Oct 20, 2023 •
edited
Loading

This PR simplifies the Resource interface and makes it more flexible:

  • Removes buffering-by-default, letting the user choose whether they need it
  • Move IterStream to top-level for clarity
  • Format + expand docstrings

Thanks @jojolebarjos for suggestions :)

@cmdoret cmdoret self-assigned this Oct 20, 2023
@cmdoret cmdoret added the refactor improving code without user-facing changes label Oct 20, 2023
jojolebarjos
jojolebarjos reviewed Oct 20, 2023
View reviewed changes
Copy link

@jojolebarjos jojolebarjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these two minor comments, this looks good to me.

gimie/io.py Outdated Show resolved Hide resolved
gimie/io.py Outdated Show resolved Hide resolved
@cmdoret cmdoret requested a review from jojolebarjos October 20, 2023 10:27
@cmdoret cmdoret merged commit 012475b into main Oct 20, 2023
@cmdoret cmdoret deleted the refactor/io-interface branch November 10, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojolebarjos jojolebarjos jojolebarjos approved these changes

Assignees

@cmdoret cmdoret

Labels
refactor improving code without user-facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmdoret @jojolebarjos