Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): update and restructure actions #90

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

supermaxiste
Copy link
Member

Changes:

  • All actions are updated to their latest version
  • All yml files are using consistent formatting and versions
  • docker-publish now triggers only for build&push for any changes to main (before it would build+build&push)
  • sphinx-docs now triggers build for PRs when docs/** changes and build+push for any changes to main

@supermaxiste supermaxiste requested a review from cmdoret October 18, 2023 12:12
@supermaxiste supermaxiste self-assigned this Oct 18, 2023
@cmdoret cmdoret linked an issue Oct 18, 2023 that may be closed by this pull request
3 tasks
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks much better now! Thanks for taking the time to bump action versions 🙌

on: [push, pull_request, workflow_dispatch]
on:
push:
branches: [main]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great! Thanks for this :)

@rmfranken
Copy link
Member

Nice work guys!! Kinda curious what's going on with this, seems like an awefully long time to publish no?
image

soon we can implement the new and released gimie on IP 😄

@supermaxiste
Copy link
Member Author

@rmfranken it is indeed long, but this action will not trigger most of the time 😄 currently it's setup to trigger only when dependencies, github action files or dockerfiles change.
Note that the title of the action has "Publish" in it, but in this case it's the building the container without publishing. Publishing happens only for changes to main.

@supermaxiste supermaxiste merged commit 19721b8 into main Oct 18, 2023
7 checks passed
@supermaxiste supermaxiste linked an issue Oct 19, 2023 that may be closed by this pull request
@cmdoret cmdoret deleted the gha-update branch October 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prevent docs rebuild on non-default branches Fix docker push CI
3 participants