Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upper bound jax version due to mrvi slowdown #3184

Merged
merged 1 commit into from
Feb 12, 2025
Merged

ci: upper bound jax version due to mrvi slowdown #3184

merged 1 commit into from
Feb 12, 2025

Conversation

ori-kron-wis
Copy link
Collaborator

@ori-kron-wis ori-kron-wis commented Feb 12, 2025 •
edited
Loading

close #3179

@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Feb 12, 2025
@ori-kron-wis ori-kron-wis self-assigned this Feb 12, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (c07a43d) to head (73cad12).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (c07a43d) and HEAD (73cad12). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (c07a43d) HEAD (73cad12)
21 3
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
- Coverage   89.43%   82.67%   -6.77%     
==========================================
  Files         185      185              
  Lines       16182    16182              
==========================================
- Hits        14473    13379    -1094     
- Misses       1709     2803    +1094

see 27 files with indirect coverage changes

@ori-kron-wis ori-kron-wis merged commit 50e8bab into main Feb 12, 2025
16 of 20 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Feb 12, 2025
@ori-kron-wis @meeseeksmachine
Backport PR scverse#3184: ci: upper bound jax version due to mrvi slo…
e3e79b7 
…wdown
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 12, 2025
Merged
ori-kron-wis added a commit that referenced this pull request Feb 12, 2025
@meeseeksmachine @ori-kron-wis
Backport PR #3184 on branch 1.2.x (ci: upper bound jax version due to…
eeb34d8 
… mrvi slowdown) (#3185)

Backport PR #3184: ci: upper bound jax version due to mrvi slowdown

Co-authored-by: Ori Kronfeld <ori.kronfeld@weizmann.ac.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justjhong justjhong justjhong approved these changes

Assignees

@ori-kron-wis ori-kron-wis

Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MrVI slowdown due to JAX compilation update
2 participants
@ori-kron-wis @justjhong