Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second possibility of updated tutorials index page #3178

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lordy5
Copy link
Collaborator

@lordy5 lordy5 commented Feb 10, 2025

No description provided.

@lordy5 lordy5 added tutorials on-merge: backport to 1.2.x on-merge: backport to 1.2.x labels Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (c07a43d) to head (03688b5).

❗ There is a different number of reports uploaded between BASE (c07a43d) and HEAD (03688b5). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (c07a43d) HEAD (03688b5)
12 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
- Coverage   89.43%   82.67%   -6.77%     
==========================================
  Files         185      185              
  Lines       16182    16182              
==========================================
- Hits        14473    13379    -1094     
- Misses       1709     2803    +1094     

see 27 files with indirect coverage changes

@lordy5
Copy link
Collaborator Author

lordy5 commented Feb 10, 2025

Screenshot 2025-02-10 at 9 39 53 AM

@canergen
Copy link
Member

Best one of the three style-wise. I don't think it will get much nicer. It will be essential to add describing text to the tutorials to make navigation easier. Maybe we disable the whole list on the left and also make it expandible subheaders.

@lordy5
Copy link
Collaborator Author

lordy5 commented Feb 11, 2025

Screenshot 2025-02-11 at 2 10 44 PM
I fixed the sidebar so it is hierarchical again, although the dropdowns look slightly different because of some changes I had to make. I will probably include the remaining changes on a new branch since things will be significantly different. Do we want to use this version while I'm working on the other features?

@lordy5 lordy5 requested a review from ori-kron-wis February 11, 2025 22:18
@canergen
Copy link
Member

Do you need to have the headings twice? Fine with me, just trying to understand whether it's some effort to have it flat within each section.

@lordy5
Copy link
Collaborator Author

lordy5 commented Feb 11, 2025

Do you need to have the headings twice? Fine with me, just trying to understand whether it's some effort to have it flat within each section.

I was trying to fix this but couldn't find a simple way without manually linking each tutorial instead of using the table of contents directive. I could do this but not sure if it's worth it since things will be changed a lot soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants