-
Notifications
You must be signed in to change notification settings - Fork 635
normalize_total
with numba
#3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for i in numba.prange(rows): | ||
count = counts_per_cell[i] / target_sum | ||
for j in range(indptr[i], indptr[i + 1]): | ||
data[j] /= count | ||
return counts_per_cell, target_sum, counts_per_cols |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this part can be in fast-array-utils under the name elem_mult
@flying-sheep right? This is what I understood from our discussions. Should we first implement elem_mult
then come back to this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I wouldn’t stop scanpy improvements for fast_array_utils
.
But if part of this can be replaced with a mult helper, we could do that now!
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3571 +/- ##
==========================================
+ Coverage 76.68% 76.74% +0.05%
==========================================
Files 113 113
Lines 12709 12703 -6
==========================================
+ Hits 9746 9749 +3
+ Misses 2963 2954 -9
|
Co-authored-by: Philipp A. <flying-sheep@web.de>
@Intron7 you have to write |
Also this needs a release note! |
@flying-sheep of course |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release note please
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Philipp A. <flying-sheep@web.de>
Co-authored-by: Phil Schaf <flying-sheep@web.de>
Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>
Co-authored-by: Phil Schaf <flying-sheep@web.de>
Co-authored-by: Intron7 <severin.dicks@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Fixes #3135
This also removes the deprecated functions out